Add unit tests for route handler #564
Conversation
socsieng
force-pushed
the
tests/routeHandler
branch
from
8a94ac4 to
feccdf1
Compare
| expect(response.statusCode).not.toEqual(404); | ||
| }); | ||
|
|
||
| it("should redirect trailing slashes", async () => { |
There was a problem hiding this comment.
I plan on being able to provide mock implementations for things like redirects to test different redirect behaviours.
There was a problem hiding this comment.
Before you go any further, i'll give my advice on this.
We shouldn't unit test big component like this routingHandler file, we should rather test the little function used inside like addNextConfigHeaders or fixDataPage
For me we should keep as little mock as possible, because otherwise at one point you risk end up testing against your mock instead.
And we also risk having to provide thousands of mock to cover all the test we need.
We could maybe reconsider this later and add integration test, but the priority right now is these small function
|
Closing this PR and replacing with #568 |
2 participants
Still a WIP progress while I try to familiarise myself with expected behaviour, but wanted some early feedback on the approach for now.