Skip to content

fix: create the directory before copying the config #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: create the directory before copying the config #566

merged 1 commit into from
Oct 17, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Oct 17, 2024

Sorry for breaking e2e :(

@vicb vicb requested a review from conico974 October 17, 2024 14:15
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 17, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@566

commit: 34b4429

conico974
conico974 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, that's why we have e2e

@vicb vicb merged commit bd2e058 into main Oct 17, 2024
3 checks passed
@vicb vicb deleted the cfd branch October 17, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@conico974 conico974 conico974 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vicb @conico974