Skip to content

Add unit tests for handling middleware #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2024
Merged

Add unit tests for handling middleware #576

merged 1 commit into from
Oct 19, 2024

Conversation

@socsieng
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 01103dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 19, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@576

commit: 01103dd

conico974
conico974 requested changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed feelings about this one (kind of the same issue than with the routingHandler )
It's fine for now i guess, we can change it later if needs be
We could add a note at the top to remind us about that

packages/open-next/src/core/routing/middleware.ts Outdated

type MiddlewareLoader = (path: string) => Promise<any>;
function defaultMiddlewareLoader(path: string) {
return import(path);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be hardcoded here.

@socsieng
Copy link
Contributor Author

It's fine for now i guess, we can change it later if needs be We could add a note at the top to remind us about that

What kind of note, and where did you have in mind?

@conico974
Copy link
Contributor

It's fine for now i guess, we can change it later if needs be We could add a note at the top to remind us about that

What kind of note, and where did you have in mind?

Something at the top of the test file.
Something like : Ideally we'd want to not test this function as a whole, but rather break it into smaller component and test these component independently

@socsieng socsieng requested a review from conico974 October 19, 2024 11:32
conico974
conico974 approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@conico974 conico974 merged commit e5338b6 into opennextjs:main Oct 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@conico974 conico974 conico974 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@socsieng @conico974