Skip to content

Conversation

@socsieng
Copy link
Contributor

@socsieng socsieng commented Oct 19, 2024

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2024

⚠️ No Changeset found

Latest commit: e143515

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socsieng socsieng force-pushed the build/test-reporter branch 3 times, most recently from cfb2b3b to 31b589d Compare October 19, 2024 06:10
@conico974
Copy link
Contributor

Do we want to add this ?
That's great when you can achieve good coverage but given the code we have, i don't think it make that much sense.
cc @khuezy

@socsieng
Copy link
Contributor Author

Do we want to add this ? That's great when you can achieve good coverage but given the code we have, i don't think it make that much sense. cc @khuezy

I thought it could serve as a reminder to include tests for future contributions

@conico974
Copy link
Contributor

Do we want to add this ? That's great when you can achieve good coverage but given the code we have, i don't think it make that much sense. cc @khuezy

I thought it could serve as a reminder to include tests for future contributions

That's a good point, but given how some stuff cannot be unit tested i wonder if it won't make people try to write test and us having to ask to remove them and having to explain this everytime.

Or maybe it won't have any effect, the changeset bot as been there for a while and almost no PR contains a changeset 😂

Btw i've checked it doesn't work right now because the GH action don't have the permission to write PR

@socsieng socsieng force-pushed the build/test-reporter branch from 31b589d to f473b4a Compare October 19, 2024 11:48
@socsieng socsieng force-pushed the build/test-reporter branch from f473b4a to e143515 Compare October 19, 2024 11:50
@socsieng
Copy link
Contributor Author

Btw i've checked it doesn't work right now because the GH action don't have the permission to write PR

I noticed that too. I set the permissions in the workflow file but I'm guessing it's related to my permissions on this repository.

I tested it out on my fork and it works as expected: socsieng#1 (comment)

It might work for subsequent pull requests after merge... 🤞

Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey sorry I missed the ping here. LGTM Thanks!

The coverage report is nice but we shouldn't get too discouraged by the coverage numbers. 100% coverage is a trap!

@khuezy
Copy link
Contributor

khuezy commented Oct 25, 2024

We can merge and figure out the permissions issues if there are any.

@conico974 conico974 merged commit 2a7be74 into opennextjs:main Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants