Don't force args for install #597
Conversation
|
commit: |
| : ""; | ||
|
|
||
| const additionalArgs = installOptions.additionalArgs ?? ""; | ||
| const installCommand = `npm install --platform=linux ${archOption} ${targetOption} ${libcOption} ${additionalArgs} ${installOptions.packages.join(" ")}`; |
There was a problem hiding this comment.
what if the platform is Windows?
There was a problem hiding this comment.
People still use windows as a server ? 😂
That's only for the server. Honestly there is probably dozens of other issue trying to run OpenNext on windows.
There was a problem hiding this comment.
I read someone was insterested in running ON on Azure 🤷
We'll cross that bridge when we get there.
2 participants
For some libs it seems that the default args that we used doesn't work, we can make all of them optional