Skip to content

fix: add more reliable sources to the revalidate e2e test #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2024
Merged

fix: add more reliable sources to the revalidate e2e test #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 11 additions & 18 deletions examples/app-router/app/revalidate-path/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,19 @@
export default async function Page() {
const timeInParis = await fetch(
"https://www.timeapi.io/api/time/current/zone?timeZone=Europe%2FParis",
{
next: {
tags: ["path"],
},
const responseSST = await fetch("https://sst.dev", {
next: {
tags: ["path"],
},
);
});
// This one doesn't have a tag
const timeInLondon = await fetch(
"https://www.timeapi.io/api/time/current/zone?timeZone=Europe%2FLondon",
);
const timeInParisJson = await timeInParis.json();
const parisTime = timeInParisJson.dateTime;
const timeInLondonJson = await timeInLondon.json();
const londonTime = timeInLondonJson.dateTime;
const responseOpenNext = await fetch("https://opennext.js.org");
const reqIdSst = responseSST.headers.get("x-amz-cf-id");
const dateInOpenNext = responseOpenNext.headers.get("date");
return (
<div>
<h1>Time in Paris</h1>
<p>Paris: {parisTime}</p>
<h1>Time in London</h1>
<p>London: {londonTime}</p>
<h1>Request id from SST</h1>
<p>RequestID: {reqIdSst}</p>
<h1>Date from from OpenNext</h1>
<p>Date: {dateInOpenNext}</p>
</div>
);
}
20 changes: 10 additions & 10 deletions packages/tests-e2e/tests/appRouter/revalidateTag.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ test("Revalidate tag", async ({ page, request }) => {
test("Revalidate path", async ({ page, request }) => {
await page.goto("/revalidate-path");

let elLayout = page.getByText("Paris:");
const initialParis = await elLayout.textContent();
let elLayout = page.getByText("RequestID:");
const initialReqId = await elLayout.textContent();

elLayout = page.getByText("London:");
const initialLondon = await elLayout.textContent();
elLayout = page.getByText("Date:");
const initialDate = await elLayout.textContent();

// Send revalidate path request
const result = await request.get("/api/revalidate-path");
Expand All @@ -86,11 +86,11 @@ test("Revalidate path", async ({ page, request }) => {
expect(text).toEqual("ok");

await page.goto("/revalidate-path");
elLayout = page.getByText("Paris:");
const newParis = await elLayout.textContent();
expect(newParis).not.toEqual(initialParis);
elLayout = page.getByText("RequestID:");
const newReqId = await elLayout.textContent();
expect(newReqId).not.toEqual(initialReqId);

elLayout = page.getByText("London:");
const newLondon = await elLayout.textContent();
expect(newLondon).not.toEqual(initialLondon);
elLayout = page.getByText("Date:");
const newDate = await elLayout.textContent();
expect(newDate).not.toEqual(initialDate);
});
Loading