Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Oct 28, 2024

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 3c68603

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vicb vicb requested a review from conico974 October 28, 2024 09:36
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 28, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@602

commit: 3c68603

@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 19.26% 1409 / 7314
🔵 Statements 19.26% 1409 / 7314
🔵 Functions 53.4% 94 / 176
🔵 Branches 67.2% 332 / 494
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/open-next/src/build/createMiddleware.ts 0% 0% 0% 0% 1, 16-17, 19, 22-27, 29-32, 34-37, 39-41, 44-48, 51-63, 65-77, 79-80
packages/open-next/src/build/createServerBundle.ts 0% 0% 0% 0% 1, 18, 20-22, 24-25, 28-33, 35-43, 48, 50, 52, 54, 57-64, 67-82, 85-100, 103-104, 106-109, 111-118, 121, 128-130, 132-136, 138-140, 143-146, 149-157, 160-163, 166, 169-175, 182-184, 186, 188-191, 193-217, 219-223, 225-231, 233-261, 263-265, 267, 269-271, 273-279, 286-288, 290-292, 296-297, 300-306, 309, 317-322, 324-325, 327-331
packages/open-next/src/build/edge/createEdgeBundle.ts 0% 0% 0% 0% 1, 34-52, 54-113, 120-122, 135-136, 138-141, 143-159, 161, 163-169, 172-173, 176, 179-184, 187-189, 191-194, 197-204, 207-214, 216-228
packages/open-next/src/core/routingHandler.ts 0% 0% 0% 0% 1, 28-30, 33-35, 38-40, 42-49, 51-58, 60-71, 73-76, 78-81, 83-87, 89-96, 100-101, 103-109, 111-115, 117, 119-125, 128-132, 134-139, 141-147, 152-154, 156, 158-159, 163-166, 168-185, 187-204, 207-210, 212-218
packages/open-next/src/core/routing/matcher.ts 75.36% 62.92% 91.66% 75.36% 36-38, 47-51, 56-58, 61, 100, 102, 105, 108, 126-127, 166-168, 269-271, 273-284, 286, 317-326, 365-378, 380-398, 400-404
packages/open-next/src/plugins/replacement.ts 0% 0% 0% 0% 1, 15-16, 52-62, 64-78, 80-81, 83, 85-99, 101-107
Generated in workflow #656 for commit 3c68603 by the Vitest Coverage Report Action

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb vicb merged commit 8624ae9 into main Oct 28, 2024
3 checks passed
@vicb vicb deleted the refactor branch October 28, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants