Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Oct 30, 2024

This is the second (and last) hack required for the middleware bundle on cloudflare.

For us the second build pass is hanlded by wrangler. This PR adds an option to disable that pass.

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 3b372b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 30, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@613

commit: 3b372b6

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 19.32% 1410 / 7298
🔵 Statements 19.32% 1410 / 7298
🔵 Functions 53.14% 93 / 175
🔵 Branches 67.27% 333 / 495
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/open-next/src/build/createMiddleware.ts 0% 0% 0% 0% 1, 19-23, 25, 28-33, 35, 39-41, 44-48, 51-65, 67-81
Generated in workflow #677 for commit 3b372b6 by the Vitest Coverage Report Action

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI you can't merge multiple PR at the same time without crashing the e2e test (the cdk cannot update an app that are already in the UPDATE_IN_PROGRESS state )
You need to wait for the end of the previous e2e test. Also something that we should rework in the future.

@vicb
Copy link
Contributor Author

vicb commented Oct 30, 2024

FYI you can't merge multiple PR at the same time without crashing the e2e test (the cdk cannot update an app that are already in the UPDATE_IN_PROGRESS state )
You need to wait for the end of the previous e2e test. Also something that we should rework in the future.

Ah cool, I was just looking at why tests failed. Thanks!

@vicb vicb merged commit dfc174d into main Oct 30, 2024
3 checks passed
@vicb vicb deleted the vb-branch-6 branch October 30, 2024 18:00
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants