Skip to content

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Oct 31, 2024

Note

this PR is matching what I am doing here: opennextjs/opennextjs-cloudflare#115
(I'm not sure if we also want an experimental branch here too?)

Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: a3cae9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 31, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 19.44% 1423 / 7318
🔵 Statements 19.44% 1423 / 7318
🔵 Functions 52.84% 93 / 176
🔵 Branches 68.2% 341 / 500
File CoverageNo changed files found.
Generated in workflow #691 for commit a3cae9f by the Vitest Coverage Report Action

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it make sense to have an experimental branch as well, other than that LGTM

@dario-piotrowicz
Copy link
Contributor Author

Yeah it make sense to have an experimental branch as well, other than that LGTM

done 🙂

Given the extra branch I've also re-aligned the text here with that of the Cloudflare adapter

please let me know if it looks all good

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for that

@dario-piotrowicz dario-piotrowicz changed the title add main prereleases add main and experimental prereleases Oct 31, 2024
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dario!

@vicb vicb merged commit f7758ac into main Nov 1, 2024
1 check passed
@vicb vicb deleted the dario/main-prerelease branch November 1, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants