Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 8, 2024

Use the code rather than the fullname.
See https://vercel.com/guides/geo-ip-headers-geolocation-vercel-functions#geolocation-headers

(cloudfront correctly uses cloudfront-viewer-region vs cloudfront-viewer-region-name)

Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: ecade9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Nov 8, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@625

commit: ecade9c

@vicb vicb requested a review from conico974 November 8, 2024 14:44
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.43% 1650 / 7355
🔵 Statements 22.43% 1650 / 7355
🔵 Functions 56.32% 98 / 174
🔵 Branches 70.57% 415 / 588
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/overrides/wrappers/cloudflare.ts 0% 100% 100% 0% 6-57
Generated in workflow #720 for commit ecade9c by the Vitest Coverage Report Action

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb vicb merged commit 9cfe371 into main Nov 8, 2024
3 checks passed
@vicb vicb deleted the cf/region branch November 8, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants