Skip to content

refactor: code simplification #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 11, 2024
Merged

refactor: code simplification #627

merged 6 commits into from
Nov 11, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 8, 2024 •
edited
Loading

A few refactors I had accumulated in a branch.

Some of them depends on recent TS which is why it's updated.

Contains the auto fixes from biome

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d8167c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 8, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@627

commit: d8167c3

@vicb
GitButler WIP Commit
e7e648f 
fixup! biome
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.48% 1648 / 7329
🔵 Statements 22.48% 1648 / 7329
🔵 Functions 56.32% 98 / 174
🔵 Branches 70.3% 412 / 586
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/adapters/dynamo-provider.ts 0% 0% 0% 0% 1-78
packages/open-next/src/adapters/server-adapter.ts 0% 0% 0% 0% 1-40
packages/open-next/src/adapters/util.ts 0% 100% 100% 0% 3-37
packages/open-next/src/build/createAssets.ts 0% 0% 0% 0% 1-246
packages/open-next/src/build/createMiddleware.ts 0% 0% 0% 0% 1-83
packages/open-next/src/build/createServerBundle.ts 0% 0% 0% 0% 1-313
packages/open-next/src/build/helper.ts 0% 0% 0% 0% 1-356
packages/open-next/src/build/edge/createEdgeBundle.ts 0% 0% 0% 0% 1-229
packages/open-next/src/core/patchAsyncStorage.ts 0% 0% 0% 0% 1-39
packages/open-next/src/core/requestHandler.ts 0% 0% 0% 0% 1-222
packages/open-next/src/core/require-hooks.ts 0% 0% 0% 0% 1-152
packages/open-next/src/core/util.ts 0% 0% 0% 0% 1-106
packages/open-next/src/core/routing/matcher.ts 78.13% 67.39% 91.66% 78.13% 36-38, 47-51, 56-58, 61, 100, 102, 105, 108, 118-119, 161-163, 272-274, 276-289, 368-407
packages/open-next/src/core/routing/util.ts 70.99% 86.66% 86.36% 70.99% 170-192, 216-265, 289-290, 358-360, 375, 486-507
packages/open-next/src/core/routing/i18n/accept-header.ts 0% 100% 100% 0% 17-141
packages/open-next/src/http/openNextResponse.ts 1.47% 0% 0% 1.47% 30-405
packages/open-next/src/http/util.ts 80% 75% 100% 80% 8-9, 13, 26-29
packages/open-next/src/overrides/converters/aws-cloudfront.ts 69.84% 80.76% 100% 69.84% 105-106, 154-213
packages/open-next/src/overrides/converters/edge.ts 0% 0% 0% 0% 1-112
packages/open-next/src/overrides/tagCache/constants.ts 0% 0% 0% 0% 1-25
packages/open-next/src/overrides/wrappers/node.ts 0% 0% 0% 0% 1-69
packages/open-next/src/plugins/replacement.ts 0% 0% 0% 0% 1-106
packages/open-next/src/types/aws-lambda.ts 0% 0% 0% 0%
packages/open-next/src/types/next-types.ts 0% 0% 0% 0%
packages/utils/src/index.ts 0% 0% 0% 0% 1-16
Generated in workflow #732 for commit d8167c3 by the Vitest Coverage Report Action

@vicb vicb mentioned this pull request Nov 8, 2024
Merged
@vicb vicb requested a review from conico974 November 8, 2024 17:30
conico974
conico974 reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question, and i don't know the answer. I need to run some test to be sure.
If you know the answer then the rest LGTM and you can merge

conico974
conico974 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@conico974 conico974 merged commit 08874fb into main Nov 11, 2024
3 checks passed
@conico974 conico974 deleted the misc/refactor branch November 11, 2024 11:49
@conico974 conico974 mentioned this pull request Nov 13, 2024
Merged
maxmorozoff added a commit to maxmorozoff/opennextjs-aws that referenced this pull request Nov 14, 2024
@maxmorozoff
Revert "chore(lint): restore useArrowFunction fixes for bound functio…
ef74bd9 
…ns and ignore rule"

This reverts commit b2a8203.
Resolved here: opennextjs#627 (comment)
conico974 pushed a commit that referenced this pull request Nov 14, 2024
@maxmorozoff
Refactor/biome code style (#628)
009332b 
* chore(lint): restore useArrowFunction fixes for bound functions and ignore rule

* chore(lint): remove linter rules from config

* chore(lint): fix noVar rule and remove from config

- Fixed linting issues related to the rule
- Restored the rule to default settings

* chore(lint): fix noImplicitAnyLet rule and remove from config

- Fixed linting issues related to the rule
- Restored the rule to default settings

* chore(lint): fix noGlobalIsNan rule and remove from config

- Fixed linting issues related to the rule
- Restored the rule to default settings

* chore(lint): fix noUselessElse rule and remove from config

* chore(lint): fix useNodejsImportProtocol rule and remove from config

* chore(lint): fix useTemplate rule and remove from config

* chore(lint): fix useDefaultParameterLast rule and remove from config

* chore(lint): fix useSingleVarDeclarator rule and remove from config

* chore(lint): fix noSwitchDeclarations rule and remove from config

* chore(lint): fix useLiteralKeys rule and remove from config

* chore(lint): fix noUselessSwitchCase rule and remove from config

* chore(lint): fix noUselessConstructor rule and remove from config

* chore(lint): fix noUselessTernary rule and remove from config

* chore(lint): fix noExtraBooleanCast rule and remove from config

* chore(lint): fix useOptionalChain rule and remove from config

* chore(lint): fix noUnusedTemplateLiteral rule and remove from config

* chore(lint): fix noAccumulatingSpread rule and remove from config

* chore(lint): ignore linter warnings

* chore(lint): update linter rules config

* chore(lint): remove <explanation> placeholder in biome-ignore comments

* Revert "chore(lint): restore useArrowFunction fixes for bound functions and ignore rule"

This reverts commit b2a8203.
Resolved here: #627 (comment)

* fixup! chore(lint): ignore linter warnings
mariiaSrDev added a commit to mariiaSrDev/nextjs-aws-adapter that referenced this pull request Sep 15, 2025
@mariiaSrDev
Refactor/biome code style (#628)
9368aac 
* chore(lint): restore useArrowFunction fixes for bound functions and ignore rule

* chore(lint): remove linter rules from config

* chore(lint): fix noVar rule and remove from config

- Fixed linting issues related to the rule
- Restored the rule to default settings

* chore(lint): fix noImplicitAnyLet rule and remove from config

- Fixed linting issues related to the rule
- Restored the rule to default settings

* chore(lint): fix noGlobalIsNan rule and remove from config

- Fixed linting issues related to the rule
- Restored the rule to default settings

* chore(lint): fix noUselessElse rule and remove from config

* chore(lint): fix useNodejsImportProtocol rule and remove from config

* chore(lint): fix useTemplate rule and remove from config

* chore(lint): fix useDefaultParameterLast rule and remove from config

* chore(lint): fix useSingleVarDeclarator rule and remove from config

* chore(lint): fix noSwitchDeclarations rule and remove from config

* chore(lint): fix useLiteralKeys rule and remove from config

* chore(lint): fix noUselessSwitchCase rule and remove from config

* chore(lint): fix noUselessConstructor rule and remove from config

* chore(lint): fix noUselessTernary rule and remove from config

* chore(lint): fix noExtraBooleanCast rule and remove from config

* chore(lint): fix useOptionalChain rule and remove from config

* chore(lint): fix noUnusedTemplateLiteral rule and remove from config

* chore(lint): fix noAccumulatingSpread rule and remove from config

* chore(lint): ignore linter warnings

* chore(lint): update linter rules config

* chore(lint): remove <explanation> placeholder in biome-ignore comments

* Revert "chore(lint): restore useArrowFunction fixes for bound functions and ignore rule"

This reverts commit b2a82030e5b1603c65bf02f13cf583fb70fc81f0.
Resolved here: opennextjs/opennextjs-aws#627 (comment)

* fixup! chore(lint): ignore linter warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@conico974 conico974 conico974 approved these changes

+1 more reviewer

@maxmorozoff maxmorozoff maxmorozoff left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicb @conico974 @maxmorozoff