Feat: Allow overriding the proxying for external rewrite #630
Conversation
commit: |
🦋 Changeset detectedLatest commit: 8ea7d39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| */ | ||
| export async function resolveWarmerInvoke( | ||
| warmer?: LazyLoadedOverride<Warmer> | "aws-lambda", | ||
| warmer?: LazyLoadedOverride<Warmer> | IncludedWarmer, |
There was a problem hiding this comment.
you update l 115 in a similar way string -> IncludedOriginResolver
There was a problem hiding this comment.
l 101 as well.
Maybe use the same as l86 everywhere
Co-authored-by: Victor Berchet <[email protected]>
| | LazyLoadedOverride<OriginResolver> | ||
| | IncludedOriginResolver; | ||
| warmer?: LazyLoadedOverride<Warmer> | IncludedWarmer; | ||
| proxyExternalRequest?: |
There was a problem hiding this comment.
nit:
- use
OverrideOptions["..."]forwarmerandproxyExternalRequest DefaultOverrideOptions<any, any>can also be changed forOverrideOptions, right?
There was a problem hiding this comment.
DefaultOverrideOptions<any, any> can also be changed for OverrideOptions, right?
Yes
OverrideOptions["..."] for warmer and proxyExternalRequest
We can't for the warmer, it is not defined in OverrideOptions
There was a problem hiding this comment.
Actually, we can't use OverrideOptions for the wrapper and the converter, it cause a few issue with typescript.
I'll revert to DefaultOverrideOptions<any,any>
| : "sqs-lite", | ||
| } | ||
| : {}), | ||
| originResolver: |
|
@conico974 can we merge this? |
|
@vicb Yeah if everything is ok for the fetch/cloudflare part |
It looks okay, I'll test this more thoroughly soon and fix any thing that would need to be fixed. Does that sound ok? |
|
(Having the dummy types will help me progress) |
2 participants
This PR add an option to override the old
proxyRequestfn that was used for external rewrites.It also automatically make the proxying when used in the external middleware, no need to do it in a converter or the wrapper.
By default it is the same as before, but it could use
fetchfor the proxying@vicb PTAL, i haven't tested the fetch part, i'd appreciate some feedback on this