Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 19, 2024

No description provided.

@vicb vicb requested a review from conico974 November 19, 2024 13:16
Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 322194c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.4% 1657 / 7397
🔵 Statements 22.4% 1657 / 7397
🔵 Functions 56.32% 98 / 174
🔵 Branches 70.42% 412 / 585
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build/copyTracedFiles.ts 0% 0% 0% 0% 1-304
packages/open-next/src/plugins/edge.ts 0% 0% 0% 0% 1-198
Generated in workflow #755 for commit 322194c by the Vitest Coverage Report Action

Copy link

pkg-pr-new bot commented Nov 19, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@634

commit: 322194c

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little comment, other than that LGTM

return;
if (f !== "server.js") {
readdirSync(path.join(standaloneNextDir, "server"))
.filter(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do it in 1 filter instead of 2, it avoids having to iterate over everything twice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we could.
however I like to have "simple" filters.
I don't think the time lost iterating a list is significant vs i/o (copy the files).

Happy to change if you feel strongly about this one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fine for me then, i don't have that strong of an opinion on this

@vicb vicb merged commit 5c0e121 into main Nov 19, 2024
3 checks passed
@vicb vicb deleted the hacks branch November 19, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants