You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR will add pnpm catalog for deps that is reused through the repo. Making it easier to maintain. I will open this in draft mode so we can continue working on it. The alternative was using something like syncpack, but that would add another dep so I decided to go with pnpm catalogs instead.
Any suggestions on what more we could add? I have considered using catalog for the other shared deps in examples/*, like f.ex tailwindcss/typescript or postcss. Not sure if we want that, and also should we consider using a caret or tilde in any of the catalog versions?
Btw, I have tested building and deploying the examples apps with this PR, and it works as it should.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@sommeeeer Yeah we should add these 3 deps and bump typescript version as well.
And we don't want to use ^ or ~, we should always use exact where we can
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sommeeeer
force-pushed
the
pnpm-catalog
branch
2 times, most recently
from
This PR will add pnpm catalog for deps that is reused through the repo. Making it easier to maintain. I will open this in draft mode so we can continue working on it. The alternative was using something like syncpack, but that would add another dep so I decided to go with pnpm catalogs instead.
Any suggestions on what more we could add? I have considered using catalog for the other shared deps in
examples/*, like f.extailwindcss/typescriptorpostcss. Not sure if we want that, and also should we consider using a caret or tilde in any of the catalog versions?Btw, I have tested building and deploying the examples apps with this PR, and it works as it should.