Skip to content

feat(build): add BuildOptions#minify to enable code minification #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024
Merged

feat(build): add BuildOptions#minify to enable code minification #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e571a7
feat(build): add BuildOptions#minify to enable code minification
vicb Nov 27, 2024
9edd647
fixup! missed that file
vicb Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/open-next/src/build/bundleNextServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const externals = [
export async function bundleNextServer(
outputDir: string,
appPath: string,
{ debug = false },
{ minify = true },
) {
const require = createRequire(`${appPath}/package.json`);
const entrypoint = require.resolve("next/dist/esm/server/next-server.js");
Expand All @@ -58,7 +58,7 @@ export async function bundleNextServer(
// packages: "external",
format: "cjs",
external: externals,
minify: !debug,
minify,
outfile: path.join(outputDir, "next-server.runtime.prod.js"),
sourcemap: false,
plugins: [
Expand Down
2 changes: 1 addition & 1 deletion packages/open-next/src/build/createServerBundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ async function generateBundle(
const isBundled = fnOptions.experimentalBundledNextServer ?? false;
if (isBundled) {
await bundleNextServer(path.join(outputPath, packagePath), appPath, {
debug: options.debug,
minify: options.minify,
});
}

Expand Down
2 changes: 1 addition & 1 deletion packages/open-next/src/build/edge/createEdgeBundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ globalThis.AsyncLocalStorage = AsyncLocalStorage;
outfile,
allowOverwrite: true,
bundle: true,
minify: !options.debug,
minify: options.minify,
platform: "node",
format: "esm",
conditions: ["workerd", "worker", "browser"],
Expand Down
14 changes: 9 additions & 5 deletions packages/open-next/src/build/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,18 @@ export function normalizeOptions(
appPackageJsonPath = findNextPackageJsonPath(appPath, monorepoRoot);
}

const debug = Boolean(process.env.OPEN_NEXT_DEBUG) ?? false;

return {
appBuildOutputPath: buildOutputPath,
appPackageJsonPath,
appPath,
appPublicPath: path.join(appPath, "public"),
buildDir: path.join(outputDir, ".build"),
config,
debug: Boolean(process.env.OPEN_NEXT_DEBUG) ?? false,
debug,
// Whether ESBuild should minify the code
minify: !debug,
monorepoRoot,
nextVersion: getNextVersion(appPath),
openNextVersion: getOpenNextVersion(),
Expand Down Expand Up @@ -98,13 +102,13 @@ export function esbuildSync(
esbuildOptions: ESBuildOptions,
options: BuildOptions,
) {
const { openNextVersion, debug } = options;
const { openNextVersion, debug, minify } = options;
const result = buildSync({
target: "esnext",
format: "esm",
platform: "node",
bundle: true,
minify: !debug,
minify,
mainFields: ["module", "main"],
sourcemap: debug ? "inline" : false,
sourcesContent: false,
Expand Down Expand Up @@ -134,13 +138,13 @@ export async function esbuildAsync(
esbuildOptions: ESBuildOptions,
options: BuildOptions,
) {
const { openNextVersion, debug } = options;
const { openNextVersion, debug, minify } = options;
const result = await buildAsync({
target: "esnext",
format: "esm",
platform: "node",
bundle: true,
minify: !debug,
minify,
mainFields: ["module", "main"],
sourcemap: debug ? "inline" : false,
sourcesContent: false,
Expand Down