Skip to content

Conversation

sommeeeer
Copy link
Contributor

Should we consider turning on this no-unused-imports in biome.jsonc?

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 88a12a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Dec 2, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@659

commit: 4573231

@vicb
Copy link
Contributor

vicb commented Dec 3, 2024

Oops, sorry that I haven't seen the PR earlier, I think I fixed a bunch of that already

@sommeeeer
Copy link
Contributor Author

Oops, sorry that I haven't seen the PR earlier, I think I fixed a bunch of that already

i saw that, i guess we can close this. should we consider adding that rule to biome? what level would you prefer?

@vicb
Copy link
Contributor

vicb commented Dec 3, 2024

should we consider adding that rule to biome? what level would you prefer?

I was thinking about that when fixing the imports. I think error is good.

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vicb vicb merged commit b5e77b0 into opennextjs:main Dec 3, 2024
1 check passed
@sommeeeer sommeeeer deleted the fix-unused-imports branch December 3, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants