Skip to content

Conversation

@dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Dec 16, 2024

this is needed to resolve opennextjs/opennextjs-cloudflare#177

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: ebc9c49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 16, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@678

commit: ebc9c49

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.93% 1724 / 7517
🔵 Statements 22.93% 1724 / 7517
🔵 Functions 56.59% 103 / 182
🔵 Branches 71.1% 438 / 616
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build/edge/createEdgeBundle.ts 0% 0% 0% 0% 1-254
Generated in workflow #835 for commit ebc9c49 by the Vitest Coverage Report Action

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nit: maybe add a comment

@vicb
Copy link
Contributor

vicb commented Dec 16, 2024

@dario-piotrowicz would be nice to link to the issue on the cloudflare adapter in the PR description.
Thanks!

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dario-piotrowicz
Copy link
Contributor Author

LGTM Thanks. Just resolve this https://github.com/opennextjs/opennextjs-aws/actions/runs/12351796922/job/34467482276?pr=678

done 🙂👍

@vicb vicb merged commit ec20b73 into main Dec 16, 2024
3 checks passed
@vicb vicb deleted the dario/__import_unsupported-cloudflare branch December 16, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Next.js 15 + middleware causes __import_unsupported error

4 participants