Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-olives-try.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@opennextjs/aws": patch
---

use correct version for applying stableIncrementalCache (It failed for next 14.0.4)
2 changes: 1 addition & 1 deletion packages/open-next/src/build/createServerBundle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ async function generateBundle(
const isBefore13413 =
buildHelper.compareSemver(options.nextVersion, "13.4.13") <= 0;
const isAfter141 =
buildHelper.compareSemver(options.nextVersion, "14.0.4") >= 0;
buildHelper.compareSemver(options.nextVersion, "14.1") >= 0;

const disableRouting = isBefore13413 || config.middleware?.external;

Expand Down
20 changes: 20 additions & 0 deletions packages/tests-unit/tests/build/helper.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { compareSemver } from "@opennextjs/aws/build/helper.js";

// We don't need to test canary versions, they are stripped out
describe("compareSemver", () => {
it("should return 0 when versions are equal", () => {
expect(compareSemver("1.0.0", "1.0.0")).toBe(0);
});

it("should return 1 when first version is greater", () => {
expect(compareSemver("1.0.1", "1.0.0")).toBe(1);
});

it("should return -1 when first version is smaller", () => {
expect(compareSemver("1.0.0", "1.0.1")).toBe(-1);
});

it("should work with latest", () => {
expect(compareSemver("latest", "1.0.0")).toBe(1);
});
});
Loading