Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Jan 24, 2025

a bit simpler interface (as I'm introducing it in cf)

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: db356cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vicb vicb requested a review from conico974 January 24, 2025 13:17
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 24, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@712

commit: db356cf

@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.99% 1922 / 8011
🔵 Statements 23.99% 1922 / 8011
🔵 Functions 51.15% 111 / 217
🔵 Branches 71.23% 483 / 678
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build/createAssets.ts 0% 0% 0% 0% 1-248
packages/open-next/src/build/generateOutput.ts 0% 0% 0% 0% 1-371
packages/open-next/src/build/helper.ts 12.28% 85.71% 5% 12.28% 21-101, 104-177, 198-216, 227-233, 244-253, 256-262, 265-266, 270-281, 313-325, 328-342, 348-358, 361-362, 365-366, 377-396, 399-400
Generated in workflow #914 for commit db356cf by the Vitest Coverage Report Action

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb
Copy link
Contributor Author

vicb commented Jan 24, 2025

Thanks for the review Nico!

@vicb vicb merged commit a3337e0 into main Jan 24, 2025
3 checks passed
@vicb vicb deleted the getBuildID branch January 24, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants