Skip to content

fix(cloudflare): enable trailiing slash redirect #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

fix(cloudflare): enable trailiing slash redirect #722

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c64941d
fix(cloudflare): enable trailiing slash redirect
vicb Feb 3, 2025
269cbac
Update packages/open-next/src/core/routing/matcher.ts
vicb Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lovely-trains-teach.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@opennextjs/aws": patch
---

fix(cloudflare): enable trailiing slash redirect
7 changes: 5 additions & 2 deletions packages/open-next/src/core/routing/matcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,8 @@ export function handleRewrites<T extends RewriteDefinition>(
function handleTrailingSlashRedirect(
event: InternalEvent,
): false | InternalResult {
const url = new URL(event.url, "http://localhost");
const emptyBody = emptyReadableStream();
// When rawPath is `//domain`, `url.host` would be `domain`.
const url = new URL(event.rawPath, "http://localhost");

if (
// Someone is trying to redirect to a different origin, let's not do that
Expand All @@ -267,6 +267,9 @@ function handleTrailingSlashRedirect(
) {
return false;
}

const emptyBody = emptyReadableStream();

if (
NextConfig.trailingSlash &&
!event.headers["x-nextjs-data"] &&
Expand Down