Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Feb 10, 2025

ESBuild recommends callbacks to be async because many can run in parallel

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: 590d433

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 10, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@732

commit: 590d433

@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 24.28% 1950 / 8028
🔵 Statements 24.28% 1950 / 8028
🔵 Functions 51.61% 112 / 217
🔵 Branches 71.34% 488 / 684
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/plugins/resolve.ts 0% 0% 0% 0% 1-118
Generated in workflow #950 for commit 590d433 by the Vitest Coverage Report Action

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb
Copy link
Contributor Author

vicb commented Feb 10, 2025

Thanks for the review!

@vicb vicb merged commit 5e92af8 into main Feb 10, 2025
3 checks passed
@vicb vicb deleted the async-esbuild branch February 10, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants