Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Feb 20, 2025

minor change but there should be not real reason to force this to be true?

@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2025

⚠️ No Changeset found

Latest commit: 9462bb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vicb vicb requested a review from conico974 February 20, 2025 11:02
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 20, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@749

commit: 9462bb2

@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 24.24% 1949 / 8039
🔵 Statements 24.24% 1949 / 8039
🔵 Functions 51.61% 112 / 217
🔵 Branches 71.61% 487 / 680
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/types/open-next.ts 0% 0% 0% 0%
Generated in workflow #987 for commit 9462bb2 by the Vitest Coverage Report Action

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there is a reason, all the other options in middleware here will have no effect if used without the middleware being external.
It was to make it clear that this should only be used for bundling the middleware separately (looks like i failed 😄 )

@vicb
Copy link
Contributor Author

vicb commented Feb 20, 2025

makes sense!

@vicb vicb closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants