Skip to content

Conversation

@sommeeeer
Copy link
Contributor

@sommeeeer sommeeeer commented Mar 3, 2025

For #763, add e2e for API routes in pagesRouter example app:

  • Hello world in /api/hello.ts
  • Dynamic API route in /api/dynamic/[slug].ts
  • Catch all route in /api/dynamic/catch-all/[...slug].ts
  • Catch all optional route in /api/dynamic/catch-all-optional/[[...slug]].ts

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏
Would be nice to have the next bug ID before merging

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: c3fbfd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for that

@conico974 conico974 merged commit 972287e into opennextjs:main Mar 3, 2025
1 check passed
@sommeeeer sommeeeer deleted the add-pages-e2e branch March 4, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants