Skip to content

fix: api routes in pages router e2e #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

fix: api routes in pages router e2e #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...src/pages/api/dynamic/precedence/route.ts → ...src/pages/api/dynamic/precedence/index.ts
View file
Open in desktop
File renamed without changes.
5 changes: 1 addition & 4 deletions packages/tests-e2e/tests/pagesRouter/api.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@ test("should work with optional catch all api route", async ({ page }) => {
expect(body).toEqual({ optional: "true" });
});

// This should work but it doesn't. It seems that the predefined api route is not taking precedence.
// Its broken in `next start` aswell.
// Issue currently open in Next: https://github.com/vercel/next.js/issues/76765
test.skip("predefined api route should take presedence", async ({ page }) => {
test("predefined api route should take presedence", async ({ page }) => {
const result = await page.goto("/api/dynamic/precedence");
expect(result?.status()).toBe(200);
const body = await result?.json();
Expand Down
Loading