Skip to content

fix: add cookies in express-dev wrapper #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2025
Merged

fix: add cookies in express-dev wrapper #776

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f85b3ec
fix: add cookies in express-dev wrapper
sommeeeer Mar 13, 2025
b862e93
flush
sommeeeer Mar 14, 2025
e42a1b8
Create smart-grapes-shake.md
conico974 Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/open-next/src/overrides/wrappers/express-dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ const wrapper: WrapperHandler = async (handler, converter) => {
const internalEvent = await converter.convertFrom(req);
const streamCreator: StreamCreator = {
writeHeaders: (prelude) => {
res.setHeader("Set-Cookie", prelude.cookies);
res.writeHead(prelude.statusCode, prelude.headers);
res.flushHeaders();
return res;
},
onFinish: () => {},
Expand Down
Loading