Skip to content

fix(converters): refactor the constructing of URL in node converter #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2025
Merged

fix(converters): refactor the constructing of URL in node converter #867

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f310788
fix in node converter to remove leading forward slashes
sommeeeer May 18, 2025
4aa5f7e
changeset
sommeeeer May 18, 2025
6daabe5
refactor
sommeeeer May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stale-rivers-invite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@opennextjs/aws": patch
---

fix: remove leading forward slashes from url in node converter
5 changes: 4 additions & 1 deletion packages/open-next/src/overrides/converters/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ const converter: Converter = {
])
.filter(([key]) => key),
);
const url = new URL(req.url!, `http://${extractHostFromHeaders(headers)}`);
const url = new URL(
req.url!.replace(/^\/\/+/, "/"),
`http://${extractHostFromHeaders(headers)}`,
);
const query = getQueryFromSearchParams(url.searchParams);
return {
type: "core",
Expand Down
Loading