Skip to content

Conversation

@sommeeeer
Copy link
Contributor

For #846

I ran into 2 problems after bumping esbuild. The first one was a warning during building with OpenNext:
image

The second problem was that onResolve filter error as indicated in the original issue.

To solve them I reordered the exports in package.json, and I also removed the /g at the end from the RegEx filter. This seemed to solve those issues.

I then built and deployed all Next versions from 12-15. I also ran the E2E for Next 14-15. It seems to work fine.

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2025

🦋 Changeset detected

Latest commit: a41ded5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 19, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@869

commit: a41ded5

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you

@conico974 conico974 merged commit 1664d83 into opennextjs:main May 19, 2025
3 checks passed
@sommeeeer sommeeeer deleted the upgrade-esbuild branch May 19, 2025 13:18
@github-actions github-actions bot mentioned this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants