fix: populate static API routes for our staticRouteMatcher

[sommeeeer]

Next filters out all static routes that starts with /api on this line from routes-manifest.json.

This makes both static API routes from page router and app router (including page.tsx in /api/* on app router) not get caught by our staticRouteMatcher cause it relies on routes-manifest.json to have those routes. If you had a catch-all route at the root (i.e: /[[...catch-all]].tsx) with fallback: false it would break all API routes cause handleFallbackFalse in routingHandler would return a 404. In this PR we include those routes and can also get rid of isApiRoute in routingHandler. As it wont be needed anymore.

I added an E2E to app-pages-router to showcase this. Without the fix in this PR the tests-e2e/tests/appPagesRouter/api.test.ts would fail, and possibly more. As we would get a 404 instead.

Reference for the Discord thread

[changeset-bot]

🦋 Changeset detected

Latest commit: b04012e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@opennextjs/aws	Patch
app-pages-router	Patch
app-router	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@875

commit: b04012e

[conico974]

LGTM Thanks

[sommeeeer]

Thanks for the reviews @conico974 !