Skip to content

fix(edge-converter): Ensure null body status codes dont return a body #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025
Merged

fix(edge-converter): Ensure null body status codes dont return a body #906

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28da16b
fix(edge-converter): Ensure null body status dont return a body
sommeeeer Jun 17, 2025
2bb4485
changeset
sommeeeer Jun 17, 2025
46ccea5
Update packages/open-next/src/overrides/converters/edge.ts
sommeeeer Jun 17, 2025
e14a354
comment
sommeeeer Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mean-crabs-ring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@opennextjs/aws": patch
---

fix(edge-converter): Ensure null body status codes dont return a body
9 changes: 8 additions & 1 deletion packages/open-next/src/overrides/converters/edge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ declare global {
var __dangerous_ON_edge_converter_returns_request: boolean | undefined;
}

const NULL_BODY_STATUSES = new Set([101, 204, 205, 304]);

const converter: Converter<InternalEvent, InternalResult | MiddlewareResult> = {
convertFrom: async (event: Request) => {
const url = new URL(event.url);
Expand Down Expand Up @@ -97,7 +99,12 @@ const converter: Converter<InternalEvent, InternalResult | MiddlewareResult> = {
}
}

return new Response(result.body as ReadableStream, {
// We should not return a body for statusCode's that doesn't allow bodies
const body = NULL_BODY_STATUSES.has(result.statusCode)
? null
: (result.body as ReadableStream);

return new Response(body, {
status: result.statusCode,
headers,
});
Expand Down
Loading