Skip to content

fix: add Vary header to cache interceptor #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 25, 2025
Merged

fix: add Vary header to cache interceptor #916

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d4fb85a
fix: add Vary header to cache interceptor
sommeeeer Jun 24, 2025
158236a
review
sommeeeer Jun 25, 2025
c9d26b1
more comment
sommeeeer Jun 25, 2025
014a944
more comment
sommeeeer Jun 25, 2025
2d969ab
Update packages/open-next/src/core/routing/cacheInterceptor.ts
sommeeeer Jun 25, 2025
e4f1532
next pr
sommeeeer Jun 25, 2025
64ee772
add Next-Url header
sommeeeer Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-ligers-decide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@opennextjs/aws": patch
---

fix: add vary header to cache interceptor
4 changes: 4 additions & 0 deletions packages/open-next/src/core/routing/cacheInterceptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ import { generateMessageGroupId } from "./queue";
const CACHE_ONE_YEAR = 60 * 60 * 24 * 365;
const CACHE_ONE_MONTH = 60 * 60 * 24 * 30;

const VARY_HEADER =
"RSC, Next-Router-State-Tree, Next-Router-Prefetch, Next-Router-Segment-Prefetch";

async function computeCacheControl(
path: string,
body: string,
Expand Down Expand Up @@ -127,6 +130,7 @@ async function generateResult(
...cacheControl,
"content-type": type,
...cachedValue.meta?.headers,
vary: VARY_HEADER,
},
};
}
Expand Down
Loading