-
Notifications
You must be signed in to change notification settings - Fork 176
fix: createAssets fails in case of broken JSON in fetch cache #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
conico974
merged 7 commits into
opennextjs:main
from
grabmateusz:feat/create-assets-json-parsing-fix
Aug 31, 2025
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1e0ee43
fix: createAssets fails in case of broken JSON in fetch cache
grabmateusz 3250ef2
Add changeset
grabmateusz 01b7575
Fix bump up from major to patch
grabmateusz 48488ce
Log information about incorrectly parsed file
grabmateusz 8d34b10
Fix remarks to PR, adjust logging
grabmateusz 504c876
Fix code review remark
grabmateusz ff07456
Fix linting
grabmateusz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@opennextjs/aws": patch | ||
--- | ||
|
||
fix: createAssets fails in case of broken JSON in fetch cache |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
export function safeParseJsonFile<T = any>(input: string, filePath: string, fallback?: T): T | undefined { | ||
try { | ||
return JSON.parse(input); | ||
} catch (err) { | ||
console.warn(`Failed to parse JSON file "${filePath}". Error: ${(err as Error).message}`); | ||
return fallback; | ||
grabmateusz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.