fix: Ensure middleware rewrite status code is properly propagated in cache interceptor #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 51e86d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
reviewed
Sep 4, 2025
sommeeeer
force-pushed
the
fix-rewrite-status-code-external-mw
branch
from
0045dca to
bf40d1d
Compare
…cache interceptor changeset fix test fix test refactor deletion of cache tags header review update test
sommeeeer
force-pushed
the
fix-rewrite-status-code-external-mw
branch
from
bf40d1d to
51e86d7
Compare
|
Alright, thanks for the review Nico! This one should be ready to go now :) |
conico974
approved these changes
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a rewrite in middleware like this:
The rewrite status code is not propogated to the cache interceptor's responses when you have an external middleware.
We can also safely remove the
x-next-cache-tagsheader on the response.I did update some tests that were flakey aswell. We need to register the event listener before the navigation.