fix(build): Refactor fallback values to be dummy overrides in createEdgeBundle #975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have
enableCacheInterception
enabledincludeCache
will be true there, meaningesbuild
will potentially bundleaws4fetch
and the fallback overrides(sqs-lite
,dynamodb-lite
&s3-lite
) in the middleware handler file. This can happen if you build from the Cloudflare adapter cause theoverrides
can contain anonymous functions and theoverride
function would returnundefined
.To see this your self, build the
examples/e2e/app-router
in cloudflare repo and look foraws4fetch
,sqs-lite
etc.. in the middleware handler file. Do we really need to pass any values here tho? I can't find any of them bundled in the middleware handler, even with this fix.