Skip to content

Conversation

dirkdev98
Copy link
Contributor

Fixes #973

I'm not sure if the added configuration option should be under dangerous, but just put it there since it changes some behavior. Also alternative names are welcome :)

Should I also create a PR to the docs repo, or is that auto-synced based on types / comment extraction?

Copy link

changeset-bot bot commented Sep 12, 2025

🦋 Changeset detected

Latest commit: 92ad102

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Minor
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@sommeeeer sommeeeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on first glance, I’ll take another look later tonight. Did you run the E2E?

@sommeeeer
Copy link
Contributor

Should I also create a PR to the docs repo, or is that auto-synced based on types / comment extraction?

No, and it would be nice to be added there.

@dirkdev98
Copy link
Contributor Author

Did you run the E2E?

Yep, the headers one specifically against a Next.js only build and the appRouter suite fully against a local OpenNext build. Had some failures on image-optimization which I haven't really looked at yet. But I assumed that's caused by only spinning up the server function.

I forgot to push the open-next.config.local.ts change, which I have added to the PR now.

Copy link

pkg-pr-new bot commented Sep 15, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@981

commit: 92ad102

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@conico974 conico974 merged commit 23ed1df into opennextjs:main Sep 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Headers from next.config override headers defined in a middleware

3 participants