-
Notifications
You must be signed in to change notification settings - Fork 174
feat: add option to align header priorization execution order #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 92ad102 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me on first glance, I’ll take another look later tonight. Did you run the E2E?
No, and it would be nice to be added there. |
Yep, the headers one specifically against a Next.js only build and the I forgot to push the |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Fixes #973
I'm not sure if the added configuration option should be under
dangerous
, but just put it there since it changes some behavior. Also alternative names are welcome :)Should I also create a PR to the docs repo, or is that auto-synced based on types / comment extraction?