-
Notifications
You must be signed in to change notification settings - Fork 181
fix: allow bypassing the Tag Cache in the interceptor #982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: fe84e30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
I'm going to add a test before merging the PR |
conico974
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!!
shouldBypassTagCachewas implemented in #944.It is useful to bypass the Tag Cache when we know that an entry has not been revalidated.
The original PR missed an updated in the cache interceptor resulting in the Tag Cache never being bypassed when it is in use.
/cc @dario-piotrowicz