Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Sep 18, 2025

shouldBypassTagCache was implemented in #944.

It is useful to bypass the Tag Cache when we know that an entry has not been revalidated.

The original PR missed an updated in the cache interceptor resulting in the Tag Cache never being bypassed when it is in use.

/cc @dario-piotrowicz

@vicb vicb requested a review from conico974 September 18, 2025 08:32
Copy link

changeset-bot bot commented Sep 18, 2025

🦋 Changeset detected

Latest commit: fe84e30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Minor
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 18, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@982

commit: fe84e30

Copy link
Contributor

github-actions bot commented Sep 18, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 27.85% 2780 / 9979
🔵 Statements 27.85% 2780 / 9979
🔵 Functions 55.26% 147 / 266
🔵 Branches 75.32% 693 / 920
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/core/routing/cacheInterceptor.ts 89.95% 69.11% 100% 89.95% 45, 56-62, 76-77, 121, 175-176, 197-199, 204-205, 216-218, 228-229, 309-310
Generated in workflow #1510 for commit fe84e30 by the Vitest Coverage Report Action

@vicb
Copy link
Contributor Author

vicb commented Sep 18, 2025

I'm going to add a test before merging the PR

@vicb vicb requested a review from conico974 September 18, 2025 10:10
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!!

@vicb vicb merged commit 3e48436 into main Sep 18, 2025
3 checks passed
@vicb vicb deleted the vicb/bypass-TagCache branch September 18, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants