Skip to content

fix: bypass next tag cache when there are no tags to check #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

fix: bypass next tag cache when there are no tags to check #988

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67d86b0
fix: bypass next tag cache when there are no tags to check
vicb Oct 1, 2025
b9e64fb
fixup! test
vicb Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rude-trains-know.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@opennextjs/aws": patch
---

fix: bypass next tag cache when there are no tags to check
4 changes: 3 additions & 1 deletion packages/open-next/src/utils/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ export async function hasBeenRevalidated(
}
const lastModified = cacheEntry.lastModified ?? Date.now();
if (globalThis.tagCache.mode === "nextMode") {
return await globalThis.tagCache.hasBeenRevalidated(tags, lastModified);
return tags.length === 0
? false
: await globalThis.tagCache.hasBeenRevalidated(tags, lastModified);
}
// TODO: refactor this, we should introduce a new method in the tagCache interface so that both implementations use hasBeenRevalidated
const _lastModified = await globalThis.tagCache.getLastModified(
Expand Down
Loading