Skip to content

refactor: improve separation of source / output paths in config #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2024
Merged

refactor: improve separation of source / output paths in config #100

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aca0e8e
refactor: use source dir to get app path in config
james-elicx Oct 14, 2024
8076b05
refactor: restructure config types
james-elicx Oct 14, 2024
807dd0a
remove source dir change
james-elicx Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/cloudflare/src/cli/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@ export type Config = {
* @returns The configuration, see `Config`
*/
export function getConfig(projectOpts: ProjectOptions): Config {
const sourceDirDotNext = join(projectOpts.sourceDir, ".next");
const dotNext = join(projectOpts.outputDir, ".next");
const appPath = getNextjsApplicationPath(dotNext).replace(/\/$/, "");
const appPath = getNextjsApplicationPath(sourceDirDotNext).replace(/\/$/, "");
const standaloneRoot = join(dotNext, "standalone");
const standaloneApp = join(standaloneRoot, appPath);
const standaloneAppDotNext = join(standaloneApp, ".next");
Expand Down