-
Notifications
You must be signed in to change notification settings - Fork 73
Pin next to the catalog version #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the benefit of pinning next
to the catalog?
If we were to have different next
versions that would simply imply that we are testing our solution with different versions of the framework, which seems like a positive thing to me?
Note
these are also unpinned: vercel-commerce/next-deps
these are pinned: create-next-app/next-deps but I'd argue that they shouldn't be
We should definitely work on improving testing (there is an issue related to that). But for now I don't want to have to update the apps (to match the latest |
It's pinned (but not to the catalog version). |
yeah sorry that's what I meant 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully agree with this change but I'm not super against it (since we're doing this in the create-next-app
example)
It's only temporary and we will improve tests as part of #108 Thanks! |
No description provided.