Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Oct 29, 2024

No description provided.

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: b2dd363

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Oct 29, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@112

commit: b2dd363

Copy link
Contributor

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit of pinning next to the catalog?

If we were to have different next versions that would simply imply that we are testing our solution with different versions of the framework, which seems like a positive thing to me?


Note

these are also unpinned: vercel-commerce/next-deps

these are pinned: create-next-app/next-deps but I'd argue that they shouldn't be

@vicb
Copy link
Contributor Author

vicb commented Oct 29, 2024

We should definitely work on improving testing (there is an issue related to that).

But for now I don't want to have to update the apps (to match the latest Next) while I'm working on the open next integration.

@vicb
Copy link
Contributor Author

vicb commented Oct 29, 2024

these are also unpinned: vercel-commerce/next-deps

It's pinned (but not to the catalog version).

@dario-piotrowicz
Copy link
Contributor

It's pinned (but not to the catalog version).

yeah sorry that's what I meant 😅

Copy link
Contributor

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully agree with this change but I'm not super against it (since we're doing this in the create-next-app example)

@vicb
Copy link
Contributor Author

vicb commented Oct 29, 2024

I don't fully agree with this change but I'm not super against it (since we're doing this in the create-next-app example)

It's only temporary and we will improve tests as part of #108

Thanks!

@vicb vicb merged commit 30bab8d into main Oct 29, 2024
7 checks passed
@vicb vicb deleted the blog branch October 29, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants