Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 22, 2024

@dario-piotrowicz @james-elicx @petebacondarwin Here is what I have been working on.
/cc @conico974 - I will never thank you enough for all the support!

disclaimers:

  • it's a preview on an "experimental" branch :)
  • I have updated the README

I have only updated the middleware example, this is how I test it (from examples/middleware):

OPEN_NEXT_DEBUG=1 node /path/to/opennextjs-cloudflare/packages/cloudflare/dist/cli/index.mjs
wrangler dev

You might see errors related to the cache - it is expected (this PR has more info)

There is still some cleanup to do:

  • Added "TODO" from this PR - more generally drop legacy stuff and migrate all to ON
  • fix(cache): make dummy cache error ignorable opennextjs-aws#641 mentioned above
  • Update all the examples and make sure tests pass
  • Drop tsup and use tsc directly (as in aws)
  • Figure out how to handle ON ALS override
  • Probably some more that I can't remember right now

Then we should work on the cache implementation.

Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: d279a84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Nov 22, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@140

commit: d279a84

@vicb
Copy link
Contributor Author

vicb commented Nov 25, 2024

Thanks for the review!

@vicb vicb merged commit f0a5f2c into experimental Nov 25, 2024
2 checks passed
@vicb vicb deleted the local/exp branch November 25, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants