Skip to content

fix(build): Do not minify OpenNext bundles #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 28, 2024
Merged

fix(build): Do not minify OpenNext bundles #144

merged 4 commits into from
Nov 28, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 28, 2024

This is required to apply string replacement patches.
Fixes #143

vicb added 2 commits November 25, 2024 20:20
@vicb
refactor: cleanup
28bc514
@vicb
fix(build): Do not minify OpenNext bundles
8828629 
This is required to apply string replacement patches.
Fixes #143
@vicb vicb requested a review from petebacondarwin November 28, 2024 07:26
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 21737d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 28, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@144

commit: 21737d3

@vicb vicb requested a review from conico974 November 28, 2024 07:31
conico974
conico974 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/cloudflare/src/cli/build/bundle-server.ts Outdated

patchedCode = patchedCode
// workers do not support dynamic require nor require.resolve
// TODO: implement for cf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note that this can be done in @opennextjs/aws, not necessarily here

@vicb
Copy link
Contributor Author

vicb commented Nov 28, 2024

Thanks for the review!

@vicb vicb merged commit 41c306e into experimental Nov 28, 2024
1 check passed
@vicb vicb deleted the local/exp branch November 28, 2024 08:25
vicb added a commit that referenced this pull request Dec 20, 2024
@vicb
fix(build): Do not minify OpenNext bundles (#144)
c10aabf 
This is required to apply string replacement patches.
Fixes #143
vicb added a commit that referenced this pull request Dec 20, 2024
@vicb
fix(build): Do not minify OpenNext bundles (#144)
6dba7fc 
This is required to apply string replacement patches.
Fixes #143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@conico974 conico974 conico974 approved these changes

@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vicb @conico974