Skip to content

Conversation

petebacondarwin
Copy link
Contributor

BREAKING CHANGE:
After this change the old way of running the tool (e.g. pnpm cloudflare) no longer works.
Going forward use the new binary name (e.g. pnpm opennextjs-cloudflare).

See #161

**BREAKING CHANGE**:
After this change the old way of running the tool (e.g. `pnpm cloudflare`) no longer works.
Going forward use the new binary name (e.g. `pnpm opennextjs-cloudflare`).

See [#161](#161)
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: f8c7cd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Dec 11, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@163

commit: f8c7cd2

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

could you please update https://github.com/opennextjs/opennextjs-cloudflare/blob/experimental/packages/cloudflare/README.md so that we have a single source of truth when we update the official doc as experimental is merged back to main.

Thanks!

@petebacondarwin
Copy link
Contributor Author

Ah! I forgot most of the work is going on in experimental. It feels like we should just merge that branch into main, no?

@petebacondarwin
Copy link
Contributor Author

I'll make a second PR against experimental.

@vicb
Copy link
Contributor

vicb commented Dec 12, 2024

Ah! I forgot most of the work is going on in experimental. It feels like we should just merge that branch into main, no?

I think that experimental is ok (I approved that other PR).
It should be merged back to main shortly and there will be other required changes (wrangler.toml, open next config, ...) so maybe do all the breaking change at once?

@vicb
Copy link
Contributor

vicb commented Dec 12, 2024

#166 was merged to experimental

@vicb vicb closed this Dec 12, 2024
@vicb vicb deleted the pbd/rename-binary branch December 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants