Skip to content

patch eval("require") calls to avoid runtime warnings #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

patch eval("require") calls to avoid runtime warnings #187

merged 1 commit into from
Dec 18, 2024
+1 −0

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Dec 18, 2024 •
edited
Loading

resolves #185

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 375cec1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vicb
vicb approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once parent PR is merged.
Thanks!

Base automatically changed from dario/experimental/28/patch-validations to experimental December 18, 2024 12:07
@dario-piotrowicz dario-piotrowicz force-pushed the dario/experimental/185/eval-require-warnings branch from 937320a to 375cec1 Compare December 18, 2024 12:15
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 18, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@187

commit: 375cec1

@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review December 18, 2024 12:16
@dario-piotrowicz dario-piotrowicz merged commit fad0bad into experimental Dec 18, 2024
6 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/experimental/185/eval-require-warnings branch December 18, 2024 12:17
vicb pushed a commit that referenced this pull request Dec 20, 2024
@dario-piotrowicz @vicb
patch eval("require") calls to avoid runtime warnings (#187)
fb64f0f
vicb pushed a commit that referenced this pull request Dec 20, 2024
@dario-piotrowicz @vicb
patch eval("require") calls to avoid runtime warnings (#187)
068033a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dario-piotrowicz @vicb