Skip to content

Conversation

james-elicx
Copy link
Collaborator

The e2es are currently failing to run due to the eval patch not being required for Next.js 14 (which the e2es are currently using).

image

This PR makes that patch optional, i.e. doesn't throw an error if the patch hasn't made any changes.

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 29da325

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Dec 18, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@190

commit: 29da325

@james-elicx james-elicx marked this pull request as ready for review December 18, 2024 19:10
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@james-elicx james-elicx merged commit baeb14d into experimental Dec 18, 2024
6 checks passed
@james-elicx james-elicx deleted the james/make-eval-patch-optional branch December 18, 2024 19:33
vicb pushed a commit that referenced this pull request Dec 20, 2024
vicb pushed a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants