Skip to content

fix: CustomRequest instantiation #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix: CustomRequest instantiation #202

merged 2 commits into from
Dec 23, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 23, 2024

fixes #201

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9652699

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 23, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@202

commit: 9652699

@vicb vicb requested a review from petebacondarwin December 23, 2024 09:42
vicb
vicb commented Dec 23, 2024
View reviewed changes
@vicb vicb mentioned this pull request Dec 23, 2024
Closed
petebacondarwin
petebacondarwin approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was quite confused by this PR as the tests didn't seem related to the fix (which I think is the change to bundle-server). I think that you have implemented the clerk middleware because it exposes the bug. Is that right?

Can you add some more context to the changeset, and maybe even to the tests. Otherwise a future developer might just remove the clerk stuff, thinking it is not testing anything useful, and then expose the code to potential regression.

dario-piotrowicz
dario-piotrowicz approved these changes Dec 23, 2024
View reviewed changes
@vicb vicb merged commit c0c1d04 into main Dec 23, 2024
7 checks passed
@vicb vicb deleted the custreq branch December 23, 2024 10:38
@vicb
Copy link
Contributor Author

vicb commented Dec 23, 2024

Thanks for the reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@james-elicx james-elicx Awaiting requested review from james-elicx

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] middleware http request method dropped

3 participants

@vicb @petebacondarwin @dario-piotrowicz