Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 27, 2024

Fix an issue with NextAuth (#206)

Creating a PR so that users can test, but need to come with a proper test

Copy link

changeset-bot bot commented Dec 27, 2024

🦋 Changeset detected

Latest commit: 2238c06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Dec 27, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@212

commit: 2238c06

Copy link
Contributor

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

The first thing that came to mind when seeing the change is that a comment could help clarify why we're not setting the value to undefined but not having the comment is not a huge deal, especially since this seems to be a bit of a specific case

Besides (and related to) the above one worry I have here is that I feel that there is nothing to prevent this code to be changed in the future reintroducing the issue, I think it would be very good if we could have some e2e testing here, but I also understand that this might be a bit overkill and not worth it right now, so I am fine skipping that too

@vicb
Copy link
Contributor Author

vicb commented Dec 28, 2024

We should definitely find a way to test that (as mentioned in the description).
I'll create a separate issue for that.
Merging as the reporter of #206 saw an improvement.

@vicb vicb merged commit b3949ce into main Dec 28, 2024
7 checks passed
@vicb vicb deleted the fix/next-auth branch December 28, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants