Skip to content

Conversation

petebacondarwin
Copy link
Contributor

No description provided.

Copy link
Contributor

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't the proper solution be updating this instead?
https://github.com/flarelabs-net/poc-next/blob/4fadf97885bba52c1a0a54e5970aab379f898f1c/.github/workflows/prereleases.yml#L38

🤔

or if you do want to keep the code as is I'd suggest to rename packagePath to packageName for clarity

@petebacondarwin
Copy link
Contributor Author

or if you do want to keep the code as is I'd suggest to rename packagePath to packageName for clarity

The comment at the top of that file refers to package-name so let's go with that.

@petebacondarwin petebacondarwin merged commit 0698638 into main Sep 23, 2024
2 checks passed
@dario-piotrowicz dario-piotrowicz deleted the fix-prereleases-2 branch September 23, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants