implement getCloudflareContext for production
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
force-pushed
the
get-cloudflare-context
branch
2 times, most recently
from
07da3c3 to
6463f2d
Compare
dario-piotrowicz
force-pushed
the
get-cloudflare-context
branch
from
6463f2d to
b753375
Compare
vicb
requested changes
Sep 25, 2024
packages/cloudflare/src/cli/build/patches/investigated/patch-cache.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Sep 25, 2024
Co-authored-by: Victor Berchet <[email protected]>
vicb
reviewed
Sep 25, 2024
vicb
reviewed
Sep 25, 2024
vicb
reviewed
Sep 25, 2024
vicb
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
getCloudflareContextutility to the@opennextjs/cloudflarepackage so that developers can use it to get the Cloudflare bindings etc...Warning
The current implementation is only for production/preview, it does not work with
next devAs part of this change I split the code in the cloudflare package into 2 sub directories,
cliandapi, the former contains the code that goes into the binary that gets run to build the worker while the latter exposes the programmatic APIs that the package offers (which is onlygetCloudflareContextright now)