-
Notifications
You must be signed in to change notification settings - Fork 73
refactor: simplify the e2e and script configs #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
commit: |
d06f957
to
6deed1a
Compare
0757bd9
to
a987f0e
Compare
a987f0e
to
f55b79f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvement 🫶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvement 🫶
@vicb this is unrelated to this PR but I wanted to mention that here I notice that we use |
Good catch. Yep, we should use |
Thanks for the review Dario! |
preview
), drop that as there is a build step beforenext dev
tests on multiple browsersdev:worker
preview:worker
topreview
- to be consistent with c3 templatesThis should make the e2e CI job much faster (timeout is reduced)