Skip to content

fix:Crypto works under node18 #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
+8 −1
Merged

fix:Crypto works under node18 #356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce63d44
fix:Crypto works under node18
nojiritakeshi Feb 9, 2025
2ed9695
Apply suggestions from code review
vicb Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-parrots-retire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@opennextjs/cloudflare": patch
---

Crypto does not generate errors even when node version is less than 18.
5 changes: 4 additions & 1 deletion packages/cloudflare/src/cli/utils/ask-confirmation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
// TODO: Drop this file when Node.js 18 is deprecated
import { randomUUID } from "node:crypto";

import Enquirer from "enquirer";

export async function askConfirmation(message: string): Promise<boolean> {
const questionName = crypto.randomUUID();
const questionName = randomUUID();

const enquirerAnswersObject = await Enquirer.prompt<Record<string, boolean>>({
name: questionName,
Expand Down