Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Feb 11, 2025

This works as epxected with pnpm dev (Next server):

http://localhost:3000/isr/1 (and 2, 3) returns the page, 4 and up return a 404

with pnpm preview, http://localhost:8787/isr/N always return a 404

[wrangler:inf] GET /isr/1 404 Not Found (69ms)

@conico974 any idea what's going on here?

Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: 6fae1b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Feb 11, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@367

commit: 6fae1b0

@conico974
Copy link
Collaborator

conico974 commented Feb 11, 2025

@vicb One thing that i could think of here is that the ISR cache is not preloaded. If it's not it will return a 404

@vicb
Copy link
Contributor Author

vicb commented Feb 11, 2025

@vicb One thing that i could think of here is that the ISR cache is not preloaded. If it's not it will return a 404

💯, that was the issue here, thanks!

I'll update the PR.

@vicb
Copy link
Contributor Author

vicb commented Feb 11, 2025

Thanks @conico974 for figuring out the issue.

I added PR to enable the cache and add tests

@vicb
Copy link
Contributor Author

vicb commented Feb 11, 2025

Thanks Nico for figuring out the issue here!

@vicb vicb merged commit 762d487 into main Feb 11, 2025
7 checks passed
@vicb vicb deleted the ISR branch February 11, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants